fix: collect script tags nested under html/head/body - #14
Merged
Conversation
Only top-level AST nodes were filtered, so normal documents like <html><body><script> returned no scripts. Walk the himalaya tree so every script element is returned. Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Only top-level himalaya nodes were filtered for
tagName === 'script'. Normal documents like<html><head>…</head><body><script src=…>returned an empty array, so callers silently missed every nested script.Embed snippets with sibling top-level
<script>tags still worked, which hid the bug in existing tests.Fix
Walk the AST and collect every
scriptelement, then map attributes as before.Validation
npm test: 4/4 passed at 100% coverage